alex created this revision. alex added reviewers: KNewStuff, ngraham, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision.
REVISION SUMMARY The isRemote check and the FIXMEs are removed, instead the result from the empty target check is properly handled. The same check as in isRemote is done in the Installation::readConfig method (line 122). If this fails a warning is given and in the engine is an error emitted. This error gets shown in the GUI. Then there are no other checks needed. TEST PLAN Delete the line TargetDir from the dolphin servicemenu knsrc file. (Dolphin repository src/settings/services/servicemenu.knsrc). Before: F8256199: Screenshot_20200423_202404.png <https://phabricator.kde.org/F8256199> After, an error message is shown: F8256197: Screenshot_20200423_202239.png <https://phabricator.kde.org/F8256197> REPOSITORY R304 KNewStuff BRANCH fix_isremote_stuff (branched from master) REVISION DETAIL https://phabricator.kde.org/D29455 AFFECTED FILES src/core/engine.cpp src/core/installation.cpp src/core/installation.h To: alex, #knewstuff, ngraham, leinir Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns