araujoluis added a comment.
In D29502#665600 <https://phabricator.kde.org/D29502#665600>, @tcanabrava wrote: > In D29502#665582 <https://phabricator.kde.org/D29502#665582>, @cfeck wrote: > > > Does the delegate ensure the text is rendered in a color visible over the colored background? > > > not yet, I talked to gustavo and he's working in an updated version of the patch. > > This is the current - not in the diff yet - version: > F8293330: image.png <https://phabricator.kde.org/F8293330> Tomaz the new patch is now available for review INLINE COMMENTS > broulik wrote in kcolorcombo.h:60 > Do we really want to leak this `struct` into public API? broulik try a solution in several ways, but it looks like this was the most convenient one found so far. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
