dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> previewjob.cpp:173
> +
> +void PreviewJob::setDefaultDevicePixelRatio(qreal defaultDevicePixelRatio) {
> + s_defaultDevicePixelRatio = defaultDevicePixelRatio;
coding style: '{' on separate line
> thumbcreator.cpp:52
> +
> +bool ThumbCreatorV3::create(const QString &path, int width, int height,
> QImage &img) {
> + return createV3(path, width, height, img, 1);
'{' on its own line for methods
> thumbcreator.h:215
> + * @param img The QImage to store the preview in.
> + * @param devicePixelRatio
> + *
docu?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D29397
To: meven, dfaure, broulik, #frameworks
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack,
michaelh, ngraham, bruns
