kossebau added inline comments.

INLINE COMMENTS

> slavebase.h:355
>       */
> -    KConfigGroup *config();
> +    KIOCORE_DEPRECATED KConfigGroup *config();
>  

Given there are still a few usages of config() left which seem not easily 
replaceable, it would be better to remove the deprecation tag for the compiler, 
to not have false warnings on those places (see e.g. http.cpp for certain 
usages still).
A deprecation tag should be only set if there is a full migration path 
available ideally, otherwise people will run into warnings they cannot do 
something about.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Reply via email to