ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I have to say, I'm very impressed overall. There are a few things I'd like to 
see changed though:
  
  folder-documents should use a single page, not the copy icon F8320517: 
Screenshot_20200514_153157.png <https://phabricator.kde.org/F8320517> I suppose 
they should all have the corner at the top right, but that can be done another 
time.
  
  folder-network is using a different style F8320527: 
Screenshot_20200514_153705.png <https://phabricator.kde.org/F8320527>
  
  folder-scripts is using a different style F8320536: 
Screenshot_20200514_154402.png <https://phabricator.kde.org/F8320536>
  
  panel elements in user-desktop should be more like the 32px version F8320540: 
Screenshot_20200514_154711.png <https://phabricator.kde.org/F8320540> The 64px 
version should be changed too, but that can be done another time.
  
  Other observations (not required, just documenting them so they aren't 
forgotten)
  
=================================================================================
  
  folder-games inner symbol looks a bit small, but that's going to be extra 
work, so I won't fault you if you'd rather do that later. The 16px version that 
you reused for the 48px symbol is a bit too small at 16px anyway, so that can 
be done another time.
  F8320524: Screenshot_20200514_153422.png 
<https://phabricator.kde.org/F8320524>
  
  Interestingly, document-print uses a different style for the smallest printer 
icon size. I think I prefer the document-print version, but that change can be 
done another time.
  F8320530: Screenshot_20200514_153936.png 
<https://phabricator.kde.org/F8320530> F8320532: Screenshot_20200514_154148.png 
<https://phabricator.kde.org/F8320532>

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Reply via email to