broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > notifybypopup.cpp:363 > + watcher->deleteLater(); > + QDBusPendingReply<uint> reply = *watcher; > + notifications.insert(reply.argumentAt<0>(), notification); I think we should do an error check and whether we got the correct argument count back but we previously also didn't do it, so probably fine REPOSITORY R289 KNotifications BRANCH geninterface REVISION DETAIL https://phabricator.kde.org/D29420 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
