On Monday 10 February 2014 09:15:23 Martin Gräßlin wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115613/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2014, 9:15 a.m.)
>
>
> Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.
>
>
> Changes
> -------
>
> Adding more people for review. IMHO Dawit has final say on what the UA
> string should look like.
Reviewboard is weird. I added that comment, but the mail sent by reviewboard
doesn't show that anywhere. It makes it look like Martin made that change.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
--- Begin Message ---
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115613/
-----------------------------------------------------------
(Updated Feb. 10, 2014, 9:15 a.m.)
Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.
Changes
-------
Adding more people for review. IMHO Dawit has final say on what the UA string
should look like.
Repository: kio
Description
-------
Drop platform name from default user agent string
The platform name (e.g. X11) was currently broken on compile time.
On Linux it returned unknown and on all other platforms the same
name as already included in the OS name.
We cannot really determine the platform name as this is a core
application and the Qt's platform name is only available in a GUI
application. Compile time is no solution as we cannot know whether
the binary is executed on X11, Wayland, Android or whatever.
Diffs
-----
src/core/kprotocolmanager.cpp f81b6797887eebd868c36b98e867eb055b05a1e2
Diff: https://git.reviewboard.kde.org/r/115613/diff/
Testing
-------
Thanks,
Martin Gräßlin
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
--- End Message ---
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
