bruns added inline comments. INLINE COMMENTS
> jobtest.cpp:502 > + // arguments 0:"-n" 1:"name" 2:"-v", 3:"value" 4:src > + arguments = QStringList {"-n", "", "-v", "", "-h", src}; > + keyIndex = 1; `std::function<QStringList(const QString&, const QString&, const QString&)> m_setXattrFormatArgs;` ... m_setXattrFormatArgs = [](const QString& attrName, const QString& value, const QString& fileName) { return QStringList{QLatin1String("-n"), attrName, QLatin1String("-v"), value, fileName}; } and do it when doing the path lookup, once. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh