ahmadsamir added inline comments.
INLINE COMMENTS
> kopenwithdialog.cpp:1009
> + if (QDir::isAbsolutePath(binaryName)) {
> + QFileInfo fi(binaryName);
> + if (fi.exists() && !fi.isExecutable()) {
It's created on the next line. Anyway my initial comment was a nit-pick... it's
a micro-optimisation for when the code goes through the if block, technically
DesktopExecParser should get the absolute path in most cases.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D29445
To: broulik, #frameworks, #vdg
Cc: ahmadsamir, dfaure, apol, kde-frameworks-devel, LeGast00n, cblack,
michaelh, ngraham, bruns
