----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/#review49463 -----------------------------------------------------------
Ship it! Ship It! - Ivan Romanov On Feb. 10, 2014, 11:35 p.m., Teo Mrnjavac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115540/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 11:35 p.m.) > > > Review request for KDE Frameworks and Ivan Romanov. > > > Repository: qca > > > Description > ------- > > KDE frameworks are built with QT_NO_CAST_FROM_ASCII defined. Some of the QCA > headers contain instances of implicit conversion of string literals into > QString, and this makes it hard for frameworks to use QCA. > This proposed change wraps those instances in QStringLiteral (Qt5) or > QString::fromUtf8 (Qt4). > > Note: submitting this to kdeframeworks because there seems to be no qca > group, and emailing the QCA maintainers. > > > Diffs > ----- > > include/QtCrypto/qca_basic.h 100c626 > include/QtCrypto/qcaprovider.h b3d40ce > > Diff: https://git.reviewboard.kde.org/r/115540/diff/ > > > Testing > ------- > > Builds fine, KSecretsService links fine against it. > > > Thanks, > > Teo Mrnjavac > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
