ahmadsamir added a comment.
In D29810#674824 <https://phabricator.kde.org/D29810#674824>, @jpalecek wrote: > In D29810#674815 <https://phabricator.kde.org/D29810#674815>, @dfaure wrote: > > > This breaks FreeBSD compilation. Please check: https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/ > > > I see. It needs the declaration of `environ`, which is only provided on GNU. Should I amend it here? This has been committed already, create a new review request. (Note that KDE has moved to Gitlab at https://invent.kde.org, best if you create a merge request there; Phabricator still works, but it's planned to become read-only). :) REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks, dfaure Cc: ahmadsamir, bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham