pino added a comment.
In D27633#619369 <https://phabricator.kde.org/D27633#619369>, @aacid wrote: > In D27633#619365 <https://phabricator.kde.org/D27633#619365>, @aacid wrote: > > > I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE? > > > > @nicolasfella can you please look at it? > > > On top of that that's a BIC change, you can't do BIC changes on KF5 repos, so revert? Even if it is not a Framework, this is still a BIC change without an SONAME bump; @nicolasfella what about bumping `KACCOUNTS_SOVERSION` in the top-level CMakeLists.txt to `2` to reflect that? REPOSITORY R155 KAccounts Integration REVISION DETAIL https://phabricator.kde.org/D27633 To: nicolasfella, bshah, leinir, #frameworks, apol Cc: pino, aacid, lbeltrame