----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115653/#review49530 -----------------------------------------------------------
Two (related) things concern me about this: You're putting stuff that references the particular Qt platform plugin name into desktop files, and you're doing it with something not prefixed with X-KDE- I'm not even sure "platform" is really the right term, since you are talking about the window system. I would suggest, at a minimum, translating between "xcb" (the Qt platform name that refers to the libraries used to implement it) and "X11" (the actual window system). - Alex Merry On Feb. 11, 2014, 10:40 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115653/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 10:40 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > Introduce a showOnCurrentPlatform method to KService > > This is inspired by showInKDE to easily exclude modules which doesn't > make any sense on the current platform. E.g. in systemsettings we > do not want services which are X11 specific if systemsettings is > executed on Wayland. > > > Diffs > ----- > > src/services/kservice.h 6bc1bb988b273c9b2e6593f5f517535701b3854d > src/services/kservice.cpp 1da29e2629c09a150acee977237a25924056e3bc > > Diff: https://git.reviewboard.kde.org/r/115653/diff/ > > > Testing > ------- > > Added "OnlyShowOnPlatforms=xcb;" to kcmbell's desktop file. Shown in > systemsettings on X, hidden on Wayland > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
