> On Feb. 11, 2014, 10:47 a.m., Alex Merry wrote: > > src/CMakeLists.txt, lines 44-45 > > <https://git.reviewboard.kde.org/r/115649/diff/1/?file=243236#file243236line44> > > > > I'd actually like to explicitly have KIOWidgets in this list, as there > > are two widgets from that library (KUrlComboRequester and KUrlRequester).
Thanks, I have added this. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115649/#review49529 ----------------------------------------------------------- On Feb. 11, 2014, 10:22 a.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115649/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 10:22 a.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kdesignerplugin > > > Description > ------- > > - Remove transitive dependencies > - Explicitly check for more dependencies that are required > - Do not check for KF5I18n since I cannot find anything that uses it > > > Diffs > ----- > > CMakeLists.txt 340d6d73d806e2853724960c27b9fc852e5ec2f3 > src/CMakeLists.txt 5b796a55395578e31c7e4b70546b36b47c557823 > > Diff: https://git.reviewboard.kde.org/r/115649/diff/ > > > Testing > ------- > > Builds. Inspected source. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
