----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115683/#review49616 -----------------------------------------------------------
Ship it! I would say it makes sense, I don't know about any benefits of name-spacing the desktop files besides feeling different and special. :) - Aleix Pol Gonzalez On Feb. 11, 2014, 9:56 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115683/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 9:56 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > David Faure. > > > Repository: extra-cmake-modules > > > Description > ------- > > Install app desktop files to share/applications, not in a kde5 subdir > > Given that binaries are all installed in PREFIX/bin, and have to avoid > clashes, doing the same for desktop files is no great issue, and > installing into a subdirectory of applications/ just complicates matters > for client code that needs to refer to the desktop file (is it > "kde5-foo[.desktop]", "kde5/foo[.desktop]" or just "foo[.desktop]"?). > > > Diffs > ----- > > kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 > > Diff: https://git.reviewboard.kde.org/r/115683/diff/ > > > Testing > ------- > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
