----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115526/#review49623 -----------------------------------------------------------
Ship it! I kind of like the m_ prefix even in Private classes, for the readability of methods in that class. But no big deal, won't veto this since Qt doesn't use m_. src/kcompletionbase.h <https://git.reviewboard.kde.org/r/115526/#comment34948> I'd remove () after KCompletion, this is about a classname, not a ctor call. - David Faure On Feb. 7, 2014, 12:08 a.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115526/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 12:08 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > ------- > > Refactor private class member variables of KCompletionBase for readability > > > Diffs > ----- > > src/kcompletionbase.h 1c1f23f > src/kcompletionbase.cpp 44d05cb > > Diff: https://git.reviewboard.kde.org/r/115526/diff/ > > > Testing > ------- > > It builds. Tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
