----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115765/#review49858 -----------------------------------------------------------
Ship it! Thanks! Very nice. I can write a porting script tomorrow morning for the other frameworks, if you want. modules/ECMGenerateHeaders.cmake <https://git.reviewboard.kde.org/r/115765/#comment35032> EGM -> ECM modules/ECMGenerateHeaders.cmake <https://git.reviewboard.kde.org/r/115765/#comment35033> Why? One can just add the RELATIVE dir to the include path to use these headers during building. I think there's no need for uninstalled lowercase forwarders, except for prefixed frameworks. - David Faure On Feb. 15, 2014, 5:42 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115765/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 5:42 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > David Faure. > > > Repository: extra-cmake-modules > > > Description > ------- > > Improve the ECMGenerateHeaders API with a variable for generated files > > ecm_generate_headers() now allows/forces the caller to collect the paths > of the generated headers, so that they can be passed to the install > command. This avoids issues of unexpected files being in the CamelCase > includes directory, both from previous builds and because of > case-insensitive file systems. > > MODULE_NAME is removed, as it is no longer desirable or necessary. > Instead, the headers are placed directly in the output directory > (usually CMAKE_CURRENT_BUILD_DIR). > > Overall, this makes ecm_generate_headers() behave much more like other > file generation macros (like the Qt ones). > > The old syntax is still supported for now, to make the porting effort > easier. > > > Diffs > ----- > > modules/ECMGenerateHeaders.cmake e98a22e91151d23d7c798ff22a33097ec2a59d10 > tests/CMakeLists.txt 4347a92d3062381253dc0f6bb7004ce6e4a5cd23 > tests/ECMGenerateHeadersTest/CMakeLists.txt PRE-CREATION > tests/ECMGenerateHeadersTest/run_test.cmake.config PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115765/diff/ > > > Testing > ------- > > It has unit tests! They pass! > > Also, I converted KCoreAddons and KParts, and it works fine with those (see > https://git.reviewboard.kde.org/r/115767/ and > https://git.reviewboard.kde.org/r/115766/). And the compatibility mode means > it works fine with the existing modules (I ran `kdesrc-build attica` and > `kdesrc-build frameworks` after removing $PREFIX/include/KF5). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
