> On Feb. 19, 2014, 12:52 p.m., Luigi Toscano wrote: > > Uhm, well, not sure about the non-usage in kde4support: I would like to > > make sure that the needed files (4.2) are really there, so I would like to > > call FindDocBookXML4 for that. > > Alex Merry wrote: > Oh, I see, it's going to look for a different version to kdoctools, right? > > Luigi Toscano wrote: > Yes, I was not clear on that: the final plan is to use 4.5 for KDocTools > and keep compatibility files and 4.2 in kde4support, to allow for a smooth > transition. > > Luigi Toscano wrote: > ... does it mean we are going to keep the modules in ECM? :) > > Alex Merry wrote: > I'd still rather not have such a niche find-module in ECM; I guess it > really depends on how much we want to avoid duplicating things in the > compatibility module (kde4support). I've added David and Kevin to the RR to > see if they have any input.
Please note that the "common" FindDocBookXML is not the current version, but the one in this review request: https://git.reviewboard.kde.org/r/115876/ Also, the version in 115876 will be changed by removing the compatibility variables, which were not used outside kdelibs and need to be fixed only in Frameworks. - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/#review50220 ----------------------------------------------------------- On Feb. 19, 2014, 11:45 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115897/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 11:45 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, David > Faure, Kevin Ottens, and Luigi Toscano. > > > Repository: extra-cmake-modules > > > Description > ------- > > Remove FindDocBook*.cmake > > These are only really useful to kdoctools, so they may as well live > there. > > (NB: after looking at how kdoctools uses the information from these files, I > suspect they won't even be needed for the compatibility macros that are > intended to end up in kde4support). > > > Diffs > ----- > > find-modules/FindDocBookXML.cmake b6d623e4e5ca40cdda4c895a19a0dc273831703a > find-modules/FindDocBookXSL.cmake a7320aed66b72c92f0286658e38b7fc32266790c > > Diff: https://git.reviewboard.kde.org/r/115897/diff/ > > > Testing > ------- > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
