On 23 February 2014 17:31, Albert Astals Cid <aa...@kde.org> wrote: > El Diumenge, 23 de febrer de 2014, a les 17:26:23, John Layt va escriure: >> >> In KF5 both KLocale and KCurrencyCode are in kde4support > > KCurrencyCode is in kunitconversion.
Ah, so it is, had missed that :-) So I guess the maintainer for kunitconversion needs to move the data files there? Now, who would that be... :-) I need to see how KCurrencyCode is being used there, and decide whether to keep it public or not. So, looking at the other users of the l10n files. kio/src/core/global.cpp - Uses them to find the default BinaryUnitDialect for the current locale, but all config files have the same default, so get rid of lookup and use same default until Qt adds support. kconfigwidgets/src/klanguagebutton.cpp - loadAllLanguages() loads the list of available languages from the config files, should probably just load the list of Qt languages? Or does it really mean the list of KDE translation languages? Perhaps we need load functions for both options, depending on the use its needed for? - Will we need a K4LanguageButton that has the old behaviour? kxmlgui/src/khelpmenu.cpp - Weird one, if there are any config files installed, then enables the "Help/Switch Language" menu item, but if you trigger the item it launches KSwitchLanguageDialog which looks for the installed translation languages for the app, which is a completely different thing. - KSwitchLanguageDialogPrivate::applicationLanguageList() needs to be made a KSwitchLanguageDialog static method that KHelpMenu can call to see if more than 1 language is available, and use that in place of the existing check. Once those changes are made, then the l10n files can go to kde4support. John. _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
