----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115982/#review50766 -----------------------------------------------------------
src/tools/ksvg2icns/ksvg2icns.cpp <https://git.reviewboard.kde.org/r/115982/#comment35625> Please only #include needed headers, instead all of QtGui. src/tools/ksvg2icns/ksvg2icns.cpp <https://git.reviewboard.kde.org/r/115982/#comment35630> Insert painter.end() here, just to be safe. src/tools/ksvg2icns/ksvg2icns.cpp <https://git.reviewboard.kde.org/r/115982/#comment35628> Could you rename those variables? "if (!path2.isEmpty() && !image.save(path2))" is a bit clearer :) src/tools/ksvg2icns/ksvg2icns.cpp <https://git.reviewboard.kde.org/r/115982/#comment35629> Use curly braces, even on single-line "if" body. - Christoph Feck On Feb. 23, 2014, 9:16 p.m., Harald Fernengel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115982/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2014, 9:16 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kiconthemes > > > Description > ------- > > This is a small tool that generates Mac OS X icon files from (oxygen) svg[z] > files. > > > Diffs > ----- > > src/CMakeLists.txt 76932ca87c7de2dc25398e1fca8916426ce7e566 > src/tools/ksvg2icns/CMakeLists.txt PRE-CREATION > src/tools/ksvg2icns/ksvg2icns.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115982/diff/ > > > Testing > ------- > > Builds on Mac OS X > > > Thanks, > > Harald Fernengel > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
