kossebau added inline comments.
Herald added a subscriber: kde-frameworks-devel.
INLINE COMMENTS
> CMakeLists.txt:91
>
> -install(EXPORT KF5AuthTargets DESTINATION "${CMAKECONFIG_INSTALL_DIR}"
> +if(TARGET KF5Auth)
> + install(EXPORT KF5AuthTargets DESTINATION "${CMAKECONFIG_INSTALL_DIR}"
This installs KF5AuthTargets.cmake based on the condition, but
KF5AuthConfig.cmake still includes the target file unconditionally, so cmake
would fail over missing the file when using find_package(KF5Auth).
So are the cmake files not used in the case to support here at all, and all of
the cmake config handling should be wrapped?
REPOSITORY
R283 KAuth
REVISION DETAIL
https://phabricator.kde.org/D7274
To: vkrause, #frameworks, cordlandwehr, apol
Cc: kossebau, kde-frameworks-devel, apol, LeGast00n, cblack, michaelh,
ahmadsamir, ngraham, bruns, vkrause
