> On Feb. 27, 2014, 10:54 a.m., Martin Gräßlin wrote: > > I think the example app needs to be more complete as I doubt that > > everything here would just work (e.g. the States). If you are unsure about > > how that should work I can schedule some time for it. > > > > Would it be possible to add some Q_PROPRERTIES to the class? E.g. > > numberOfDesktops or currentDesktop might make more sense with a property > > instead INVOKABLE. > > Ivan Čukić wrote: > My thoughts exactly. > > One thing I was thinking about is to create a qml api that is not > mirroring the actual c++ api. It is not really object/property oriented. > > Ivan Čukić wrote: > What do you guys think about a data model for windows, filterable against > screen, desktop, activity containing things like title, icon, position/size, > ... that would be a properly behaving model? > > That way, it would be awesomely trivial to connect it to window thumbnail > items and so on. > > Yes, I am volunteering :) > > Martin Gräßlin wrote: > > What do you guys think about a data model for windows > > we have that in KWin, feel free to take it as a base > (kwin/scripting/scripting_model.(hcpp)). As I'm the only copyright holder I > allow the relicense to the frameworks license. > > Martin Klapetek wrote: > > Would it be possible to add some Q_PROPRERTIES to the class? E.g. > numberOfDesktops or currentDesktop might make more sense with a property > instead INVOKABLE. > > Yeah, can do that. > > > I think the example app needs to be more complete > > Well it's an example app, showing how to use the declarative > plugin...does it really need to go over all the methods? > > Martin Gräßlin wrote: > > does it really need to go over all the methods? > > how do you make sure that the methods actually work without ever writing > a test QML script? As said I don't think those methods with enums will work > in QML. > > Martin Klapetek wrote: > QML also doesn't like WId...can it be safely transformed back and forth > to long? > > Martin Gräßlin wrote: > the API needs to stay as WId. I don't know how one could transform it to > make QML happy.
<ivan|home> mck182: don't do anything - we are going to replace it :) <mck182> well I imagine these would be complementary? <ivan|home> i don't know - I'd rather go first for the model, and then see what is missing from the api <ivan|home> instead of having it duplicated <ivan|home> the approach I took for kactivities is - model, and then add mothods like setCurrentActivity and stuff to it ...so I'm stopping the work on this for now. Truth is I don't need it anymore and I was just going to finish what I started. So I'll wait what Ivan will come up with and then continue or discard this. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/#review51011 ----------------------------------------------------------- On Feb. 27, 2014, 10:23 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115932/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 10:23 a.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: kwindowsystem > > > Description > ------- > > Adds a declarative plugin usable from QML. Usage is as easy as > "KWindowSystem.workArea(0)" in QML. So far only the workArea is accessible, > not sure which other methods should be. All of them? > > I've made the import version to match the framework version, so you'd do > "import org.kde.kwindowsystem 5.0" > > > Diffs > ----- > > declarative/kwindowsystemplugin.h PRE-CREATION > CMakeLists.txt cbae838 > declarative/CMakeLists.txt PRE-CREATION > declarative/kwindowsystemplugin.cpp PRE-CREATION > declarative/qmldir PRE-CREATION > src/kwindowsystem.h e10f7c1 > tests/test.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115932/diff/ > > > Testing > ------- > > Works > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
