I had made similar proposal for 3.22 around 8-9 months ago and due to my mistakes about terminology that time you scolded/harshed me :) [ It is not a big problem and i accept the mistakes which i had done and sorry for saying KDE instead of KDE Plasma/Frameworks ] https://mail.kde.org/pipermail/kde-core-devel/2025-March/092409.html
My 2 cents are +1 for this proposal. On the other hand VERIFY_INTERFACE_HEADER_SETS looks like added in 3.24 not 3.23 : https://cmake.org/cmake/help/latest/prop_tgt/VERIFY_INTERFACE_HEADER_SETS.html#prop_tgt:VERIFY_INTERFACE_HEADER_SETS So if is it possible could it be 3.24 to make everything butter smooth ? Ömer Fadıl Usta PGP key : 0xfd11561976b1690b about.me/omerusta Albert Astals Cid <[email protected]>, 15 Ara 2025 Pzt, 01:46 tarihinde şunu yazdı: > I would like to increase cmake requirement of KDE Frameworks to 3.23. > > This way we can use CMAKE_VERIFY_INTERFACE_HEADER_SETS that checks that > each > of the headers is "compilable" on its own. > > Proof of concept on > https://invent.kde.org/frameworks/karchive/-/merge_requests/80 > > Where i have changed the code so that it compiles but so that kar.h would > not > be "compilable" on it's own. > > I'm mostly sure that our headers are possibly good, but some extra > checking > does not hurt. > > cmake 3.23 was released on July 2022. > > Looking at https://repology.org/project/cmake/badges it seems it should > not be > problematic at all. > > What do you all think? > > Cheers, > Albert > > P.S: I guess it'd be better to come up with a policy but I had no idea > what to > suggest :D > > >
