----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116573/ -----------------------------------------------------------
Review request for KDE Frameworks and David Faure. Repository: kio Description ------- Don't include klocalizedstring.h from slavebase.h. It's odd and it was not specified by CMakeLists.txt (the alternative is to move KI18n to LINK_PUBLIC). Diffs ----- src/ioslaves/help/kio_help.cpp 38e09d5 src/ioslaves/http/http.cpp a0193a0 src/ioslaves/ftp/ftp.cpp 706c983 src/core/slavebase.h 86f1506 src/core/slavebase.cpp 1236ad5 src/ioslaves/file/file.cpp b8c6220 src/ioslaves/file/file_unix.cpp 96fd6af Diff: https://git.reviewboard.kde.org/r/116573/diff/ Testing ------- Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
