> On Feb. 25, 2014, 12:10 p.m., David Faure wrote: > > The part of the description that says "if accepted will modify kstyle as > > well" doesn't really make sense anymore (to fix if it's in your commit log > > too). > > > > The bit I'm not sure about is: using MainToolbar icon style everywhere ... > > how does that take care of other toolbars then? > > The idea (long ago) was to be able to have (large) icons and text in the > > main toolbar, and (small) icons only in other toolbars. Is that idea > > dropped, or handled elsewhere? > > Hugo Pereira Da Costa wrote: > "The bit I'm not sure about is: using MainToolbar icon style everywhere > ... how does that take care of other toolbars then?" > Thing is, old code was treating 'main ToolBar' as 'other toolbars'. New > one (iiur) treats 'other toolbars' as 'main toolbar'. > The latter is as 'incomplete' as the former, but more consistent. > Not sure where exactly the distinction between 'main' and 'all' toolbars > is performed. Alex ? Is it kapplication ? (as opposed to Qt only, which has > no such distinction) ? > > David Faure wrote: > I know consistency is better than inconsistency, but still, while looking > at this we might as well make it correct, too :) > > The logic used to be in KToolBar, based on objectName == "mainToolBar" > (yes, you could say that's ugly and fragile, but since that comes from the > kxmlgui ui_standards.rc file, it actually happens automatically in all apps). > > I'm not sure what's the plan for making this work in the QToolBar+KF5 > world. But if nothing else has been planned already, kstyle and/or > platformtheme [I'm not sure why they both handle toolbar icon sizes] can take > care of checking the objectName too, given a pointer to the toolbar.
The style is indeed able to have that pointer to the toolbar, so it could be a simple if there. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116044/#review50807 ----------------------------------------------------------- On Feb. 25, 2014, 12:34 p.m., Hugo Pereira Da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116044/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 12:34 p.m.) > > > Review request for KDE Frameworks and Àlex Fiestas. > > > Repository: frameworkintegration > > > Description > ------- > > This is a spinoff of https://git.reviewboard.kde.org/r/112335/ originally > from afiestas > Copying his own words: > > In the qplatformplugin we use information from MainToolbar (which makes > sense) but in the styles we use information from Toolbar. > This unify both by using MainToolbar in styles > Code has been removed from oxygen now that it derives from KStyle again > > > Diffs > ----- > > src/kstyle/kstyle.cpp c0528b3 > > Diff: https://git.reviewboard.kde.org/r/116044/diff/ > > > Testing > ------- > > > Thanks, > > Hugo Pereira Da Costa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
