> On March 4, 2014, 9:11 p.m., David Faure wrote: > > autotests/kconfigtest.cpp, line 86 > > <https://git.reviewboard.kde.org/r/115875/diff/2/?file=251983#file251983line86> > > > > Just curious, what's the reason for the ".." then? Doesn't this still > > make this test potentially conflict with other tests that use kdeglobals? > > Alexander Richardson wrote: > Yeah it does. But now only tests using kdeglobals are a problem, before > it deleted the whole ~/.qttest/config directory which means all config files > were lost.
So why not just remove that "../" ? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review51961 ----------------------------------------------------------- On March 4, 2014, 8:58 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115875/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 8:58 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfig > > > Description > ------- > > kconfigtest: write everything into a subdirectory > > This test keeps deleting the whole ~/.qttest directory. By moving all data > into a subdirectory it is now possible to run multiple tests that use > kconfig in parallel. > > > Diffs > ----- > > autotests/kconfigtest.cpp 1c0dc1cf63539e29236ab57e1e848930b468053a > > Diff: https://git.reviewboard.kde.org/r/115875/diff/ > > > Testing > ------- > > Test still passes. No files (except kdeglobals) are created in > ~/.qttest/config > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
