----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116681/#review52470 -----------------------------------------------------------
Ship it! Looks correct. Yes, the port from KStandardDirs is quite fragile :/. - Aleix Pol Gonzalez On March 9, 2014, 9:18 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116681/ > ----------------------------------------------------------- > > (Updated March 9, 2014, 9:18 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Looking at the code it seems that QStandardPaths::locateAll() does not add > the final '/' as the previous kdelibs code. > > Without this fix kio-help does find the documentation. > > General remark: maybe other parts of code which use QStandardPaths should be > checked. > > > Diffs > ----- > > src/ioslaves/help/kio_help.cpp 85b7975 > > Diff: https://git.reviewboard.kde.org/r/116681/diff/ > > > Testing > ------- > > kioclient cat help:/kioslave/ftp (from frameworks branch of kde-runtime) now > works. > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
