-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116650/
-----------------------------------------------------------

(Updated March 10, 2014, 4:16 p.m.)


Review request for Build System and KDE Frameworks.


Changes
-------

My patch was indeed very wrong. Attempt 2:

Use the full path to create the targets, rather than just the directory name.


Repository: kdoctools


Description
-------

While porting the documentation in kde-runtime I realized there was an error 
because when running cmake it would try to create different targets and some of 
them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, 
and it uses the directory name to figure out the filename).

I would have fixed that, but then I realised it was not running any command and 
nothing depended on it. Am I missing something?


Diffs (updated)
-----

  KF5DocToolsMacros.cmake 6567b67 

Diff: https://git.reviewboard.kde.org/r/116650/diff/


Testing
-------

Now kde-runtime documentation builds.


Thanks,

Aleix Pol Gonzalez

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to