> On March 18, 2014, 10:47 a.m., Nicolás Alvarez wrote: > > src/kguiaddons_config.h.cmake, line 2 > > <https://git.reviewboard.kde.org/r/116866/diff/3/?file=255187#file255187line2> > > > > Do these copyright lines really apply to this new file? I think you > > should include just your own name (since you created this config file).
Oops, I just copied that header from another .h file... - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53348 ----------------------------------------------------------- On March 18, 2014, 10:25 a.m., Michael Hansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116866/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 10:25 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kguiaddons > > > Description > ------- > > Use std::isnan from <cmath> instead of isnan from <math.h>, as MinGW-32 on > Windows does not include the latter. This keeps the _isnan hack for MSVC, > since that compiler doesn't include either standard version :(. > > > Diffs > ----- > > src/CMakeLists.txt 624d2e109be5c26af9781101a005b4a163361a92 > src/ConfigureChecks.cmake PRE-CREATION > src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 > src/kguiaddons_config.h.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116866/diff/ > > > Testing > ------- > > Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC > 4.8 (Arch x86_64). > > > Thanks, > > Michael Hansen > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
