----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116935/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kinit Description ------- Remove use of KLibrary in KLauncher All the non-valgrind code paths that invoke kioslave let it do the lookup of the module, so the valgrind path can as well. Also adjusted the USE_KPROCESS_FOR_KIOSLAVES code path so that the kioslave executable is actually included in the arguments to valgrind. Diffs ----- src/klauncher/klauncher.cpp a8630854af4bd3094b9688c3f9a40d10516d2056 Diff: https://git.reviewboard.kde.org/r/116935/diff/ Testing ------- In combination with https://git.reviewboard.kde.org/r/116934/ Ran KDE_SLAVE_VALGRIND=file kdeinit5 and use the kioslavetest app to copy a file; the copy was successful, and the terminal running kdeinit5 output kdeinit5: preparing to launch '/usr/bin/valgrind' ==20134== Memcheck, a memory error detector ==20134== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al. ==20134== Using Valgrind-3.9.0 and LibVEX; rerun with -h for copyright info ==20134== Command: /home/kf5-devel/kf5/lib64/kde5/libexec/kioslave kio_file file local:/tmp/runtime-kf5-devel/klauncherJ19850.slave-socket local:/tmp/runtime-kf5-devel/kioslavetestJ20122.slave-socket ==20134== (20134)/(default) [31m[34mmain[0m: trying to load "kio_file" from "/home/kf5-devel/kf5/lib64/plugins/kf5/kio_file.so" ==20134== ==20134== HEAP SUMMARY: ==20134== in use at exit: 5,846 bytes in 42 blocks ==20134== total heap usage: 998 allocs, 956 frees, 672,987 bytes allocated ==20134== ==20134== LEAK SUMMARY: ==20134== definitely lost: 0 bytes in 0 blocks ==20134== indirectly lost: 0 bytes in 0 blocks ==20134== possibly lost: 0 bytes in 0 blocks ==20134== still reachable: 5,846 bytes in 42 blocks ==20134== suppressed: 0 bytes in 0 blocks ==20134== Rerun with --leak-check=full to see details of leaked memory ==20134== ==20134== For counts of detected and suppressed errors, rerun with: -v ==20134== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 1 from 1) Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
