----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ -----------------------------------------------------------
(Updated March 23, 2014, 12:23 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kservice Description ------- Remove defunct plugin-loading code, and deprecate KLibrary KLibrary::factory() tried to load kde3-style plugins (not unreasonable to drop support for) and kdelibs4-style plugins (which do not work, since they depended on Qt support). It now does nothing. This and the KPluginFactory::findPlugin() method leave KLibrary with no purpose, so deprecate it. Improve the KPluginLoader documentation Give KPluginLoader a public static findPlugin method I noticed that several bits of code used KLibrary or KPluginLoader to find a plugin, then proceeded to just use QLibrary to resolve functions from it. This method allows that to be done without actually creating a KPluginLoader instance that is then only used for its fileName() method. Diffs ----- src/plugin/kpluginloader.h 8621914890bf704213d33108d01032a7b36b3484 src/plugin/kpluginloader.cpp 53d6bc2aa8d8f91f296943ad8831ff6aaab6b3e6 src/plugin/klibrary.h 78f0701e01b0a24e8895127640ce575e09d93d7c src/plugin/klibrary.cpp c77ec32dbb1cbd1ccd6342a082012d2c82575fb8 Diff: https://git.reviewboard.kde.org/r/116938/diff/ Testing ------- Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel