----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117018/ -----------------------------------------------------------
Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen. Repository: kguiaddons Description ------- Use qIsNaN() instead of isnan() Revert "Use std::isnan on compilers that support it" This reverts commit b0b7e84f75f9b9edfbe9ef8b60f56f85c4a7800c. As apol pointed out, qIsNaN would be a better choice. Fun fact: the Qt docs claim qIsNaN() is defined in QtGlobal, but you actually have to include QtNumeric. Diffs ----- src/CMakeLists.txt f15264e01849b00907afedc262078225ed8756a5 src/ConfigureChecks.cmake c194dfc5ce54c8c7fb3b0475a704f3165ce5cca1 src/colors/kcolorutils.cpp 5f4d0fdeb77d40d42b824c99e08e208aed6f2b93 src/kguiaddons_config.h.cmake 8d5cb897a7e431be298c2d290369b14dbaaa4904 Diff: https://git.reviewboard.kde.org/r/117018/diff/ Testing ------- Builds, installs, tests pass (Linux, GCC 4.8). Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel