----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117020/#review54089 -----------------------------------------------------------
This review has been submitted with commit b6133f2fe506e195a8a8e964c43ef8de21fd4423 by Alex Merry to branch master. - Commit Hook On March 24, 2014, 2:07 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117020/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 2:07 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kde4support > > > Description > ------- > > Fix up KLibLoader autotests > > They now test the actual current state of KLibLoader (eg: only Qt5-style > plugins using KPluginFactory are supported). > > Improve KLibLoader documentation > > Also, add some extra deprecation warnings. > > Gut K_EXPORT_COMPONENT_FACTORY and make it print a deprecation warning > > There is no code left to load these plugins, which have been deprecated > since kdelibs 4.0. > > Use KPluginLoader in KLibLoader::factory() > > This actually has some chance of succeeding (KLibrary::factory() always > returns 0). > > > Diffs > ----- > > src/kdecore/klibloader.cpp bdbdf166964eecef3c534d7fe196fa70dd733c9e > src/kdecore/klibloader.h 55950b6a0ea2916d558bbbc01912f4731ec669d0 > autotests/klibloadertest_module.h > autotests/klibloadertest_module.cpp > e434cc46a7c7843186cb0fc4747f876fd5a86bc4 > autotests/klibloadertest4_module.h > autotests/klibloadertest4_module.cpp > 5179baf6c64228ad6ff50d1733e149740ddedc45 > autotests/klibloadertest.cpp 11c14b22d98069ee727d653d41a266b2dcabd820 > autotests/klibloadertest.h 84b28ad208159122ef9e8f655b9f8d66d9088ec5 > autotests/CMakeLists.txt c82e3129fc937f54f11db52d553b7f8717c0fffe > > Diff: https://git.reviewboard.kde.org/r/117020/diff/ > > > Testing > ------- > > Builds, installs, tests pass. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel