> On March 25, 2014, 3:23 p.m., Mark Gaiser wrote: > > src/staticxml/staticxmlprovider.cpp, line 80 > > <https://git.reviewboard.kde.org/r/116998/diff/1/?file=256388#file256388line80> > > > > iconurl = QUrl::fromLocalFile(xmldata.attribute("icon")); > > > > Or am i missing something obvious now?
Heh, that was silly of me :-) - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116998/#review54127 ----------------------------------------------------------- On March 25, 2014, 2:37 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116998/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 2:37 p.m.) > > > Review request for KDE Frameworks. > > > Repository: knewstuff > > > Description > ------- > > Remove reference to KDE4_BUILD_TESTS CMake option > > > Clean up comments about KConfig > > > Fix KUrl->QUrl porting > > QUrl::setPath() does not behave like KUrl::setPath(). Also removed two > very old FIXMEs: the purpose of the condition is clear now (but it was > probably unnecessary when it used KUrl from kdelibs4), and no-one > noticed any issues with the icon URLs during KDE 4, so KUrl probably did > behave as expected. > > Remove completely out-of-date README.kdxs > > > Diffs > ----- > > docs/README.kdxs f9843068b964f8e3e0a4fec37f938ceb9bba727e > src/core/engine.cpp 4bcd774e4cdb116fa40e5f2dc7bca2acdeff6224 > src/staticxml/staticxmlprovider.cpp > 56a25654a70a3628573d85adf4a1c49010f23309 > src/uploaddialog.cpp 35f34b30d4dc74c93794cb7862d65364685939d1 > tests/README.tests 7b590b823b394ca340e14d6729b4229f49946852 > > Diff: https://git.reviewboard.kde.org/r/116998/diff/ > > > Testing > ------- > > Builds, installs. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
