----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/#review54215 -----------------------------------------------------------
Ship it! I think it makes sense, it's not linking with KService. One of the good things of testing different compilers. :) - Aleix Pol Gonzalez On March 26, 2014, 4:05 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117089/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 4:05 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION > > Using KSERVICE_EXPORT causes errors on Windows since it expands to > __declspec(dllimport) or __declspec(dllexport) depending on whether it is > being build or the header is being used. Since we are not building KService > when K_EXPORT_PLUGIN_VERSION is being used we get the following error: > error C2491: 'kde_plugin_version' : definition of dllimport data not allowed > > > Diffs > ----- > > src/plugin/kexportplugin.h 15d9d7fd91b0b6ed7f32a422a18c61f16bee34bd > > Diff: https://git.reviewboard.kde.org/r/117089/diff/ > > > Testing > ------- > > compiles now > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
