----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/#review54254 -----------------------------------------------------------
I like the cleaning up, but maybe you're being too picky for preferring resetIndex to reset? - Aleix Pol Gonzalez On March 24, 2014, 9:45 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116969/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 9:45 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > ------- > > Deprecate reset() and substitute it for resetIndex(). > > Remove private reset() and move the implementation to the public reset() > > Move method to public Q_SLOTS section > > > Diffs > ----- > > autotests/kcombobox_unittest.cpp 1479ae2 > src/khistorycombobox.h d1f5eac > src/khistorycombobox.cpp 80261ae > > Diff: https://git.reviewboard.kde.org/r/116969/diff/ > > > Testing > ------- > > It builds. Tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
