----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117036/#review54310 -----------------------------------------------------------
Ship it! Ship It! - Kevin Ottens On March 24, 2014, 10:15 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117036/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 10:15 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > ------- > > Refactor private variables and parameters in KCompletionBase and KLineEdit > > Also get rid of KCompletionBase::setup() > > > Diffs > ----- > > src/klineedit.cpp b426767 > src/kcompletionbase.h edce7d4 > src/kcompletionbase.cpp f1cf347 > src/klineedit.h 723cb42 > > Diff: https://git.reviewboard.kde.org/r/117036/diff/ > > > Testing > ------- > > It builds and tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel