----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117122/ -----------------------------------------------------------
Review request for KDE Frameworks, Albert Astals Cid and John Layt. Repository: kio Description ------- I was going through the kde-runtime localization thread again [1] and decided to start looking into it. As Albert pointed out, there's many modules making use of these, one would be KIO. I looked into the actual dependency and saw that it's rather small so decided to just drop it. In this case it's using the country/entry.desktop file to check what binary format to use, but then it seems like no entry.desktop file is specifying it [2], so it's a bit of an absurd configuration settings. I just changed it to stop reading the value. [1] https://www.mail-archive.com/kde-frameworks-devel@kde.org/msg11839.html [2] ~/kde5/share/locale/l10n$ grep -R BinaryUnitDialect C/entry.desktop:BinaryUnitDialect=0 Diffs ----- src/core/global.cpp 99ab2e7 Diff: https://git.reviewboard.kde.org/r/117122/diff/ Testing ------- Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
