> On March 27, 2014, 8:31 p.m., Alex Merry wrote: > > modules/ECMTrLoader.cpp.in, line 19 > > <https://git.reviewboard.kde.org/r/117052/diff/2/?file=257837#file257837line19> > > > > QLatin1String() when you're using +
Why? That doesn't make sense on my book. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/#review54369 ----------------------------------------------------------- On March 27, 2014, 3:26 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117052/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 3:26 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > This simplifies translation handling for frameworks using Qt translation > system. > > > Diffs > ----- > > modules/ECMSetupQtTranslations.cmake PRE-CREATION > modules/ECMTrLoader.cpp.in PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117052/diff/ > > > Testing > ------- > > Here is a patch which make kbookmarks use it: > http://agateau.com/tmp/kbookmarks-tr.diff . The necessary changes for the > Messages.sh part of the patch are being reviewed for inclusion in the > l10n-kde4 repository. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
