----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ -----------------------------------------------------------
Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description ------- Add a new test that just checks kicondialog The old kicondialogtest actually tested KIconButton. That is now renamed to kiconbuttontest, and there is a new kicondialogtest that tests KIconDialog. KIconDialog: do not connect to a signal that does not exist QDialog::finished(int) does what we want, so use that instead. Diffs ----- tests/CMakeLists.txt b3b4c90a9ffbc9df81dd008f9cfbc668866fafe3 tests/kiconbuttontest.cpp PRE-CREATION src/kicondialog.cpp 4b241c1591b321486c925ef5e61f09bc7b6ddd1c tests/kicondialogtest.cpp 66432ba878a4133ea3210089d3fdfbaec145bf1b Diff: https://git.reviewboard.kde.org/r/117271/diff/ Testing ------- Tested with the new kicondialogtest, and everything seems to be in order. The old kiconbuttontest is not working properly, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel