> On April 11, 2014, 7:32 a.m., Martin Gräßlin wrote: > > I'm wondering whether it's still needed in kwindowsystem at all. So the > > test might not be telling much.
my task to remove the dependency from kwindowsystem failed: it's already no longer used. I'm just wondering where we have code which still uses this X11_XCB, it might be possible to delete it. It's in fact only needed for Qt4 as with Qt5 one gets the xcb_connection_t* through QX11Info. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117491/#review55425 ----------------------------------------------------------- On April 10, 2014, 8:40 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117491/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 8:40 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > Martin Gräßlin. > > > Repository: extra-cmake-modules > > > Description > ------- > > Rework FindX11_XCB.cmake > > Imported target, version handling, package description etc. > > > Diffs > ----- > > find-modules/FindX11_XCB.cmake e2c18a99873dc6db572c9761e5b15bddc3505fea > > Diff: https://git.reviewboard.kde.org/r/117491/diff/ > > > Testing > ------- > > Configured and build KWindowSystem successfully. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel