----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080/ -----------------------------------------------------------
(Updated April 16, 2014, 6:47 p.m.) Status ------ This change has been discarded. Review request for KDE Frameworks. Repository: kio Description ------- Use Qt5 new signal slot syntax for KDirModelTest This allows removing #define connect(...) QVERIFY(QObject::connect(...)), since now the connections are checked at compile time. Also removed all disconnect calls at the end of a test, now this is done in cleanup() which is automatically called after each test case Always use QTestEventLoop (as is the case now already) This merely removes the #define and #ifdefs for it Diffs ----- autotests/kdirmodeltest.h b8b41ec52a61a083c6c76e9184a556835551443e autotests/kdirmodeltest.cpp 5d59eba45495de30db5e70da2e80bb3d5cba424c Diff: https://git.reviewboard.kde.org/r/117080/diff/ Testing ------- Test still passes (except for testFontUrlWithHost, but that has always timed out for me) Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
