----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117652/ -----------------------------------------------------------
Review request for Build System and KDE Frameworks. Repository: kwallet Description ------- Using the gcrypt-config shell script won't work on Windows. I wrote a new find module from scratch. It now searches for the library and include directory the usual CMake way (find_library and find_path). It supports version checking by extracting the version number from the gcrypt.h header. By the way, lxr shows there are four different copies of FindLibGcrypt.cmake in different KDE projects and they all have one flaw or another. I think none uses FindPackageHandleStandardArgs, for example. Maybe we should consider putting this one into ECM for kwallet and the others to share. Diffs ----- CMakeLists.txt 9aad9c0 cmake/FindLibGcrypt.cmake 45c0d5d src/runtime/kwalletd/backend/CMakeLists.txt 4c36767 Diff: https://git.reviewboard.kde.org/r/117652/diff/ Testing ------- Tested on Windows with MSVC2010, cmake 2.8.12, finding emerge-built libgcrypt. Also tested on Debian Linux, cmake 2.8.12.1, finding the distro's libgcrypt. Thanks, Nicolás Alvarez
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
