----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review56124 -----------------------------------------------------------
src/plugin/kdbusservicestarter.cpp <https://git.reviewboard.kde.org/r/117604/#comment39148> A serviceType isn't a service. This should say "Couldn't start service" << dbusService << "for" << serviceType << ":" << err; - David Faure On April 20, 2014, 10:22 a.m., David Jarvie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117604/ > ----------------------------------------------------------- > > (Updated April 20, 2014, 10:22 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kservice > > > Description > ------- > > When KDBusServiceStarter::findServiceFor() fails to start the requested > service after it is found to not be running, it does not return the error > string. This patch fixes that and makes it behave as in the apidox. > > This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except > that the qDebug line has been uncommented on the grounds that it reports an > error. > > > Diffs > ----- > > src/plugin/kdbusservicestarter.cpp 6f011bd > > Diff: https://git.reviewboard.kde.org/r/117604/diff/ > > > Testing > ------- > > Tested for review 116951. > > > Thanks, > > David Jarvie > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
