> On April 28, 2014, 5:23 p.m., Burkhard Lück wrote: > > KF5DocToolsMacros.cmake, lines 220-221 > > <https://git.reviewboard.kde.org/r/117805/diff/1/?file=268668#file268668line220> > > > > kio/docs/kioslave/foo/CMakeLists.text have > > INSTALL_DESTINATION ${HTML_INSTALL_DIR}/en SUBDIR kioslave5/foo > > > > but the lang docbooks will not have SUBDIR kioslave5/ > > that seems to be wrong > >
I made the function uses the subdir between docs/ and the docbook file to figure out the SUBDIR argument. Tested it with the kio repository by placing a docbook file in po/fr/docs/kioslave5/file/index.docbook. It installed in $PREFIX/share/doc/HTML/fr/kioslave5/file/index.cache.bz2 - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117805/#review56764 ----------------------------------------------------------- On April 30, 2014, 2:33 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117805/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 2:33 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > This function makes it easy to install all .docbook of a framework. It is > similar to ki18n_install() (see https://git.reviewboard.kde.org/r/117804/ ). > > The primary user of this function is the build system of the framework > tarballs. The tarballs will ship with a po/ directory which follows the > structure expected by kdoctools_install(). The only necessary change is to > add the following lines to the root CMakeLists.txt file: > > if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po") > kdoctools_install(po) > endif() > > Since the code checks for the presence of a po/ directory, it can be > committed in the framework repository (no need for the tarball release > scripts to alter the CMake files), making it easier for developers to > reproduce the situation of a released tarball by creating/copying a po/ > directory in their working copy. > > > Diffs > ----- > > KF5DocToolsMacros.cmake c4e33bd > > Diff: https://git.reviewboard.kde.org/r/117805/diff/ > > > Testing > ------- > > Tested with fake content on kiconthemes, with and without the po dir. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
