----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117919/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kcoreaddons Description ------- This completes a "KDE5" porting task for KCoreAddons, by moving KAboutData::LicenseKey and KAboutData::NameFormat enums into KAboutLicense. This is mostly a mechanical port, however the requirement to keep the deprecated (for KF5) KAboutData ctor requires moving the KAboutLicense class ahead of KAboutData in the header. I wonder why we have this along with K4AboutData however, surely it would make sense to have unported apps simply use that (or declare a license) instead? I also removed the deprecated (since KDE 4) single-license accessors since multiple licenses are possible. Finally the test suite was updated (a lot of tests relating to single-license calls were removed). If the single-license calls are necessary those can be added back as well but they've been deprecated for awhile, and there is K4AboutData available. Diffs ----- autotests/kaboutdatatest.cpp f4f4f18 src/lib/kaboutdata.h a87141e src/lib/kaboutdata.cpp 82da19b Diff: https://git.reviewboard.kde.org/r/117919/diff/ Testing ------- KCoreAddons builds, tests pass, but I would imagine downstream code needs porting after this to fix the naming of the license in its KAboutData ctor. Thanks, Michael Pyne
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
