> On May 1, 2014, 9:58 a.m., Alex Merry wrote: > > modules/ECMPoQmTools.cmake, lines 25-27 > > <https://git.reviewboard.kde.org/r/117823/diff/2/?file=270239#file270239line25> > > > > I wonder if it would be better to actually just have this as an extra > > argument. I mean, it's easy enough to make the frameworks use > > ecm_install_po_files_as_qm(po ${LOCALE_INSTALL_DIR}) > > or > > ecm_install_po_files_as_qm(PODIR po DESTINATION ${LOCALE_INSTALL_DIR}) > > or something like that. > > Aurélien Gâteau wrote: > I'd rather follow the "convention over configuration" approach here. This > argument can always be added later if needed.
OK, let's go with that for now, then. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117823/#review57049 ----------------------------------------------------------- On May 2, 2014, 8:55 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117823/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 8:55 a.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > This patch adds a ecm_install_po_files_as_qm() function to > ECMCreateQmFromPoFiles.cmake. This function makes it easy to install all the > .po files of a Qt-translated framework. > > The primary user of this function is the build system of the framework > tarballs. The tarballs will ship with a po/ directory which follows the > structure expected by ecm_install_po_files_as_qm(). The only necessary change > is to add the following lines to the root CMakeLists.txt file: > > if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po") > ecm_install_po_files_as_qm(po) > endif() > > Since the code checks for the presence of a po/ directory, it can be > committed in the framework repository (no need for the tarball release > scripts to alter the CMake files), making it easier for developers to > reproduce the situation of a released tarball by creating/copying a po/ > directory in their working copy. > > We need this function (or something similar) because the way we are going to > organize po files in the framework tarballs have changed: the current CMake > code expects the po files to contain files named '<domain>-<lang>.po', but > the final structure is going to be '<lang>/<domain>.po'. > > This new function works similarly to ki18n_install() ( > https://git.reviewboard.kde.org/r/117804/ ) and kdoctools_install() ( > https://git.reviewboard.kde.org/r/117805/ ) > > > Diffs > ----- > > modules/ECMCreateQmFromPoFiles.cmake 7457fc5 > modules/ECMPoQmTools.cmake PRE-CREATION > modules/ECMQmLoader.cpp.in 2d8531f > tests/CMakeLists.txt 171f44a > tests/ECMPoQmToolsTest/CMakeLists.txt PRE-CREATION > tests/ECMPoQmToolsTest/check_tree.cmake.in PRE-CREATION > tests/ECMPoQmToolsTest/po/es/install-test.po PRE-CREATION > tests/ECMPoQmToolsTest/po/fr/install-test.po PRE-CREATION > tests/ECMPoQmToolsTest/test.po PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117823/diff/ > > > Testing > ------- > > Modified kbookmarks to call ecm_install_po_files_as_qm(). Works as expected. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
