----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117944/#review57243 -----------------------------------------------------------
This review has been submitted with commit 51eca9b6a8220e25ff3c469d757185651c9242e5 by Alex Merry to branch master. - Commit Hook On May 2, 2014, 2:23 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117944/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 2:23 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kimageformats > > > Description > ------- > > Rewrite the PIC image format handler > > It now uses QDataStream to deal with endianness. It also supports > several QImageIOHandler options. > > This comes with a more comprehensive test suite than the old code. Note > that the old test suite was incorrect as the old code wrote the floats > in the header out incorrectly (although no-one noticed because no > software seems to care about those values). > > All the test PIC files in the test suite appear correct according to the > specification (by inspection with Okteta). Unfortunately, there is a > lack of other freely-available software that reads and writes PIC files > (the main application that uses them is proprietary), and so this is the > best I can do. > > > Diffs > ----- > > autotests/CMakeLists.txt 86c540c81b6a15f908b9435a2309d9123a6ab1d4 > autotests/long-runs.pic PRE-CREATION > autotests/pic/4x4-alpha-uncompressed.pic PRE-CREATION > autotests/pic/4x4-alpha.pic PRE-CREATION > autotests/pic/4x4-alpha.png PRE-CREATION > autotests/pic/4x4-simple-color-uncompressed.pic PRE-CREATION > autotests/pic/4x4-simple-color.pic PRE-CREATION > autotests/pic/4x4-simple-color.png PRE-CREATION > autotests/pic/long-comment.pic PRE-CREATION > autotests/pic/long-runs.pic PRE-CREATION > autotests/pic/long-runs.png PRE-CREATION > autotests/pic/short-comment.pic PRE-CREATION > autotests/pictest.cpp PRE-CREATION > autotests/read/pic/bw.pic 552c2e8eb15e30018ae365a5994e8d8d9a9d442e > autotests/read/pic/bw.png e2d506bb3da276c09b8f9388dc8ad6b96f987f5e > autotests/read/pic/bwa.pic affc603bebdd64a1d63b5477f6c71e827405733b > autotests/read/pic/bwa.png a75415012846b5eead134ac502aa740c0cf1cfa7 > autotests/read/pic/rgb.pic f8a1b9cf58589d407006a6b64eefe37b6786d6a8 > autotests/read/pic/rgb.png 267d67841ad5f80e0f36cbf514c33d6e9cac146b > autotests/read/pic/rgba.pic 05fed0fccecb597d236d30fd020e681a96ea69a6 > autotests/read/pic/rgba.png cb0cae071b4e59cd18f168bb93f824b93bab3aa8 > autotests/write/bw.pic 552c2e8eb15e30018ae365a5994e8d8d9a9d442e > autotests/write/bwa.pic affc603bebdd64a1d63b5477f6c71e827405733b > autotests/write/rgb.pic f8a1b9cf58589d407006a6b64eefe37b6786d6a8 > autotests/write/rgba.pic 05fed0fccecb597d236d30fd020e681a96ea69a6 > src/imageformats/CMakeLists.txt 59472ae49e473faa7ab78db6eb9f3623fd7b6a4b > src/imageformats/pic.h add0a35bb205b989d4485cec83ce49c23c701ded > src/imageformats/pic.cpp 9d8a7ede31c5c03a699d6a76c88aeb5e3d37ac4a > src/imageformats/pic_read.cpp 484c63426723e04e5c7e96ae5355ccceccab03f4 > src/imageformats/pic_rw.h 2cc958927403de57049bbd7cb3200f0b7489da3c > src/imageformats/pic_write.cpp 0632eebd507e58e480856b53e71c24afc543de26 > > Diff: https://git.reviewboard.kde.org/r/117944/diff/ > > > Testing > ------- > > Autotests now all pass. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
