> On May 4, 2014, 2:17 p.m., Luigi Toscano wrote: > > The patch compiles, and non-gui kio clients like kio_info and kio_gopher > > (which use a KIconLoader) works (tested through kioclient cat). > > > > If no one else objects and this is approved, would you please mention that > > this setting has not been configurable for a long time as discussed on IRC?
Thanks for testing. If no one objects, I am going to commit this tomorrow. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117987/#review57256 ----------------------------------------------------------- On May 4, 2014, 2:01 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117987/ > ----------------------------------------------------------- > > (Updated May 4, 2014, 2:01 p.m.) > > > Review request for KDE Frameworks and Luigi Toscano. > > > Repository: kiconthemes > > > Description > ------- > > Using QPixmap::defaultDepth() causes a crash when the icon loader is only > used get icon paths and the application is only a QCoreApplication. > > > Diffs > ----- > > src/kiconloader.cpp 501367a > > Diff: https://git.reviewboard.kde.org/r/117987/diff/ > > > Testing > ------- > > None, I currently have no KF setup to test. > > > Thanks, > > Christoph Feck > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel