----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118127/#review57926 -----------------------------------------------------------
Ship it! Good catch, thanks! - Alex Merry On May 14, 2014, 1:11 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118127/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 1:11 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > If a variable like CMAKE_INSTALL_LIBDIR is defined as a normal variable > rather than a cache variable, including KDEInstallDirs fail because it tries > to set cache-specific properties on the variable. > > > Diffs > ----- > > kde-modules/KDEInstallDirs.cmake 6102d9e > tests/CMakeLists.txt cc11aec > tests/KDEInstallDirsTest/CMakeLists.txt PRE-CREATION > tests/KDEInstallDirsTest/not_cache_variable/CMakeLists.txt PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118127/diff/ > > > Testing > ------- > > Added test case to reproduce the issue. Does not fail anymore. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
